Aug 23, 2016 - Gayrimenkul Tasimacilik Pazarlama. Ithalat Ihracat ve Ticaret Ltd. Sirketi), and their seven associates (Luqman. Yasin Yunus Shgragi, Yunus Luqman. Yasin Shgragi, Abd Al Hakim Luqman. Jasim Muhammad, Muhammad 'ulwan. Al-Shawi, Ala al-S
Just as there is no loss of basic energy in the universe, so no thought or action is without its effects,
Idea Transcript
Semmle 1.15
Pages / … / Inefficient code
Inefficient string constructor Created by Documentation team, last modified by Documentation team on Dec 12, 2016
Category: Maintainability > Inefficient code Description: Finds code that uses the java.lang.String(String) constructor. Since Strings are immutable, the allocated object is functionally indistinguishable from the argument, thus it is more memoryefficient to use the argument directly whenever possible. The String class is immutable; there is no way to change the string which it represents. As a result, there is rarely a need to copy a String object or construct a new instance based on an existing string.
Example def sayHello(world: String) { val hello = new String("Hello ") // BAD val message = new String(hello + world) // BAD println(new String(message)) // BAD } Recommendation Remove the new expression and instead use the argument to the string. For example, replace new String(message) by simply message.
References J. Bloch. Item 5: Avoid creating unnecessary objects. Effective Java (second edition). Addison-Wesley, 2008. Java API Documentation: String(java.lang.String)